Desktop: Directly upload frame buffer#2930
Merged
Merged
Conversation
TrueDoctor
force-pushed
the
directly_upload_frame_buffer
branch
from
3ce88dc to
99e906c
Compare
Member
|
after disabling gpu the correct way, I get perfect frames and chromium browser level performance and responsiveness. |
timon-schelling
force-pushed
the
directly_upload_frame_buffer
branch
from
e2c9fce to
1249236
Compare
timon-schelling
approved these changes
Jul 25, 2025
| _ui_frame_buffer: Option<wgpu::Texture>, | ||
| window_size_sender: Sender<WindowSize>, | ||
| _viewport_frame_buffer: Option<FrameBuffer>, | ||
| _viewport_frame_buffer: Option<wgpu::Texture>, |
Member
There was a problem hiding this comment.
This will not be used In the future right?
I think you should remove both frame buffers
adamgerhant
changed the title
TrueDoctor
force-pushed
the
directly_upload_frame_buffer
branch
from
5cce137 to
7b4c54d
Compare
TrueDoctor
force-pushed
the
directly_upload_frame_buffer
branch
from
7b4c54d to
c64f4c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #2541.
Bypass copying the frame buffer data to an intermediate vec for improved performance.
